little Bug in Yabook?

Get help with installation and running YaBook guestbook here. Please do not post bug reports or feature requests here.

Moderators: Moderator Team, Development Team

little Bug in Yabook?

Postby ReMark on Fri Oct 15, 2004 11:07 am

Hi Philip,

I've just installed Yabook (which I like very much so far), when I found some strange behaviour:

When I'm logged in as "admin" and want to edit a guestbook entry all values of this entry get deleted after submitting the form. With E_NOTICEs switched on I see some of the following notices:
Code: Select all
Notice: Undefined variable: yaboform in D:\webs\yabook\private\actions.inc.php on line 169

in line 169 the code reads like that:
Code: Select all
'name'       => $HTMLLIB->unhtmlentities(trim($yaboform['name'])),

obviously $yaboform doesn't exist at this line ... looking at the "default" action, I found following line which I then inserted in line 164 too:
Code: Select all
$yaboform = Sd_Query::get('yaboform', Sd_Query::VT_POST);

now the sent form-values are in $yaboform. If you leave notices switched on you'll find another notice because of line 172:
Code: Select all
'boolybcode' => ($yaboform['ybcode_on']) ? '{TRUE}' : '{FALSE}',

I changed this to
Code: Select all
'boolybcode' => (isset($yaboform['ybcode_on'])) ? '{TRUE}' : '{FALSE}',

and everything is fine. (same problem at line 219)

I hope this helps, if I'm completely wrong, don't hesitate to let me know.

Thanks for providing your software to the public.

keep up your good work,
Gabriel

ps: I'm currently experimenting with your Sourdough framework ... 'til now I'm quite happy with it, but I only managed to use some DB-stuff, which was a breeze ... I hope the other parts are as easy to use as that (templating, forms etc.)

pps: I know, most people turn E_NOTICE off, but that sometimes leads to unclean code (especially because most programmers are lazy people). As I see in config.inc.php of Yabook, you think the same (error_reporting(E_ALL)), don't you?
website templates, flash intros and business logos

http://remarkabletemplates.com
User avatar
ReMark
 
Posts: 1
Joined: Fri Oct 15, 2004 10:09 am

Return to YaBook Support

Who is online

Users browsing this forum: No registered users and 1 guest

cron