PHPee.com PHP development forum
little Bug in Yabook?

 
Post new topic   Reply to topic    phpee.com Forum Index -> YaBook Support
View previous topic :: View next topic  
Author Message
ReMark



Joined: 15 Oct 2004
Posts: 1

PostPosted: Fri Oct 15, 2004 10:07 am    Post subject: little Bug in Yabook? Reply with quote
Hi Philip,

I've just installed Yabook (which I like very much so far), when I found some strange behaviour:

When I'm logged in as "admin" and want to edit a guestbook entry all values of this entry get deleted after submitting the form. With E_NOTICEs switched on I see some of the following notices:
Code:
Notice: Undefined variable: yaboform in D:\webs\yabook\private\actions.inc.php on line 169

in line 169 the code reads like that:
Code:
'name'       => $HTMLLIB->unhtmlentities(trim($yaboform['name'])),

obviously $yaboform doesn't exist at this line ... looking at the "default" action, I found following line which I then inserted in line 164 too:
Code:
$yaboform = Sd_Query::get('yaboform', Sd_Query::VT_POST);

now the sent form-values are in $yaboform. If you leave notices switched on you'll find another notice because of line 172:
Code:
'boolybcode' => ($yaboform['ybcode_on']) ? '{TRUE}' : '{FALSE}',

I changed this to
Code:
'boolybcode' => (isset($yaboform['ybcode_on'])) ? '{TRUE}' : '{FALSE}',

and everything is fine. (same problem at line 219)

I hope this helps, if I'm completely wrong, don't hesitate to let me know.

Thanks for providing your software to the public.

keep up your good work,
Gabriel

ps: I'm currently experimenting with your Sourdough framework ... 'til now I'm quite happy with it, but I only managed to use some DB-stuff, which was a breeze ... I hope the other parts are as easy to use as that (templating, forms etc.)

pps: I know, most people turn E_NOTICE off, but that sometimes leads to unclean code (especially because most programmers are lazy people). As I see in config.inc.php of Yabook, you think the same (error_reporting(E_ALL)), don't you?
_________________
website templates, flash intros and business logos

http://remarkabletemplates.com
Back to top
View user's profile Send private message Visit poster's website
Post new topic   Reply to topic    phpee.com Forum Index -> YaBook Support All times are GMT + 1 Hour
Page 1 of 1

 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB
Theme design based on Team 101 Designs, modified by Philip Iezzi